FIX Set type on bandpass frequency arguments. #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satra
added a commit
that referenced
this pull request
Feb 18, 2015
FIX Set type on bandpass frequency arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor correction, but the example resting state scripts do not correctly specify the variable type for the arguments. This causes issues with negative values. The string "-1" evaluates as true in the
bandpass_filterfunction on the lineif lowpass_freq > 0:, which does not produce the intended effect of suppressing the lowpass filter.I am happy to write tests for this, although I don't see any tests associated with the example scripts. Let me know if there is anything else I can do to help.